fix: presignature storage locks #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppca
pushed a commit
that referenced
this pull request
Oct 30, 2024
* basic redis setup in the same container * formatting * basic presignature-storage using redis * presignature storage wrapped in arc and ewlock * presignature storage redis functions implemented * redis presignature storage used in presignature manager * serialization for presignature * warnings fixed * presignature bad parameters error check * min refactoring * added redis config file path to dockerfile, added tf to mount /data volume * it fix * rust 2024 requirements * start redis in it * pull redis in it * lock file update * redis unit test * comments 1 * comments 2 * triple manager functions renamed to match presiganture manager * serialization simlified * comments 3 * added start command to mpc-node and added redis URL format * use account id as a part of redis storage key * added full redis config, modified dockerfile to use it * unnecessary port expose removed * remove local redis config * redis config update * redis file ownership change * fix persistent data issue * fix redis unit test * extend redis lifecycle * clippy * datastore triple storage removed * refactor triple storage * use redis to store triples * fix rust typing issue * 2 triple pre-check added * add link to redis in setup-env * use redis connection pool * fmt * change info to debug in storage layer * rename count to lem * develop * Fix locks being acquired incorrectly (#914) * chore: removed Arc and RwLock for triple/presignature storage (#915) * Removed Arc and RwLock for triple/presignature storage * fix conflicts * changing dev workflow file to target Sig.Network AR --------- Co-authored-by: kmaus-near <kody.maus.bluepisces@near.org> Co-authored-by: Phuong Nguyen <ChaoticTempest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutability and lock acquisition was being done incorrectly, where multiple write locks were trying to be acquired